login button label
Posted Thu, 09/08/2011 - 10:24 by 1189255322@facebook

Hi all,
my installation of DfF works fine except for a problem with the login button.
This is the page:
http://www.montescaglioso.net/user/register

This is the generated code:

<div class="fb-login-button"><a class="fb_button fb_button_medium"><span class="fb_button_text"><fb:login-button></fb:login-button></span></a><a class="fb_button fb_button_medium"><span class="fb_button_text"><fb:intl>Accedi tramite Facebook</fb:intl></span></a></div>

Two different links are generated. The first one is empty and clickable, the second one is with the correct string but not clickable and not working.

Any idea?
Is it a javascript problem?

many thanks in advance
felice

‹ 6.x-3.0-rc17 no longer supported facebook connect ›

fixed

by Dave Cohen - 09/09/2011 - 19:23

Should be fixed now.

http://drupal.org/node/1273828

It's not the DIV

by 1189255322@facebook - 09/09/2011 - 10:22

Hi guys,
I cannot say if FB changed something or some javascritpts conflict.
I solved this issue with a little modification in fb.theme.inc at line 28 (I'm using version 6.x-3.0-rc16 of DFF):

  $button = '<fb:login-buttonx ' . drupal_attributes($options['attributes']) . '>' .
    ($text ? '<fb:intl>' . check_plain($text) . '</fb:intl>' : '') . '</fb:login-buttonx>';

Just added a letter x to the "fb:login-button" tag. I know that's not a real solution. At least this workaround let my users properly connect to facebook when surfing my site.

Please let me know if you find a better and more clean solution.
regards
felice

Could be the div!

by Dave Cohen - 09/09/2011 - 01:14

Someone recently posted that a wrapper div with class="fb-login-button" causes problems like this. So, if that div is part of your markup, and not facebook's you have to change the class to something that doesn't start "fb-".

Please let us know if that turns out to be the problem.

same here

by what happens now - 09/08/2011 - 22:30

That double button thing just started happening to me today. I don't think I've changed anything in Drupal that would have made it happen, and it happens in all the places the Facebook Connect button is used (the login block, the registration page and the log in page).

Makes me wonder if Facebook have changed something.

Help

by what happens now - 09/08/2011 - 22:48

I'm absolutely stumped by this.

Here's my login page - http://www.joecrabtree.com/user

There's very little going on on that page. I can't figure out why the Facebook Login button is showing up twice. If you look in the source code it's there twice so something weird is happening with the module.

Plus, only the partially hidden button works, so I may be losing sign ups if people don't try clicking the little bit sticking out.

I thought it might be to do with the fact that I was renaming the button in the Facebook for Drupal prefs, so I disabled that. It still happened.
I tried disabling and re-enabling the Facebook connect module. No difference there.

If anyone figures this out please let me know: joe (at) joecrabtree.com

Like I said, it only started to happen today and I haven't made any changes to any of the Facebook stuff.

Here's the source code that's generating the two buttons...


Login with Facebook

Thanks,
Joe

Same Behavior here.

by 599379939@facebook - 09/09/2011 - 02:19

Could it be because Facebook have changed something ?

I am running an earlier version of drupal for facebook. Should I upgrade ?

Best regards,

SOLVED!

by what happens now - 09/09/2011 - 12:38

I upgraded to the latest build but it didn't make a difference.

Dave said it could be to do with a wrapper div with class="fb-login-button"

That does seem to be the problem. It's in the file fb_user.module on line 553 :
'#prefix' => '<div class="fb-login-button">',

I just added an x to the end :

'#prefix' => '<div class="fb-login-buttonx">',

And the problem has gone away.